feat(flatkv): include legacyDB in ApplyChangeSets, LtHash, and read path#2978
Merged
blindchaser merged 3 commits intomainfrom Feb 27, 2026
Merged
feat(flatkv): include legacyDB in ApplyChangeSets, LtHash, and read path#2978blindchaser merged 3 commits intomainfrom
blindchaser merged 3 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
===========================================
+ Coverage 58.13% 64.02% +5.89%
===========================================
Files 2111 14 -2097
Lines 173464 1276 -172188
===========================================
- Hits 100847 817 -100030
+ Misses 63666 344 -63322
+ Partials 8951 115 -8836
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+387
to
+397
| for _, pw := range s.legacyWrites { | ||
| if pw.isDelete { | ||
| if err := batch.Delete(pw.key); err != nil { | ||
| return fmt.Errorf("legacyDB delete: %w", err) | ||
| } | ||
| } else { | ||
| if err := batch.Set(pw.key, pw.value); err != nil { | ||
| return fmt.Errorf("legacyDB set: %w", err) | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
yzang2019
approved these changes
Feb 25, 2026
cody-littley
approved these changes
Feb 27, 2026
yzang2019
added a commit
that referenced
this pull request
Feb 27, 2026
* main: (66 commits) feat(flatkv): include legacyDB in ApplyChangeSets, LtHash, and read path (#2978) Deflake mempool tests with Eventually-based block waits (#2983) Demote noisy gasless classification log to debug level (#2982) Harden `TestStateLock_NoPOL` against proposal/timeout race (#2980) added a config parameter to limit outbound p2p connections. (#2974) merged unconditional and persistent peers status (#2977) Fix race between file pruning and in-flight parquet queries (#2975) fix(giga): don't migrate balance on failed txs (#2961) Fix hanging upgrade tests by adding timeouts to wait_for_height (#2976) Add snapshot import for Giga Live State (#2970) Fix Rocksdb MVCC read timestamp lifetime for iterators (#2971) Reduce exposed tendermint RPC endpoint (#2968) Deflake `TestStateLock_NoPOL` by widening propose timeout in test (#2969) go bench read + write receipts/logs for parquet vs pebble (#2794) [giga] clear up cache after Write (#2827) fix: use correct EVM storage key prefix in benchmark key generation (#2966) Harden staking precompile test against CI flakiness (#2967) Don't sync flatKV DBs when committing (#2964) Fix flaky `TestStateLock_POLSafety1` (#2962) Add metrics for historical proof success/failure rate (#2958) ...
yzang2019
pushed a commit
that referenced
this pull request
Feb 27, 2026
…ath (#2978) ## Describe your changes and provide context - legacy keys (codesize, address mappings, etc.) were silently ignored in FlatKV — not written to legacyDB, not included in LtHash integrity hash, and not readable via Get(). This adds full legacyDB support across the write path, commit batches, LtHash computation, and read path. ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change