Asset editor improvements#224
Conversation
|
Updated PR title and the initial comment |
|
Rebased commits on origin/master |
|
Last two commits add:
|
7635b5d to
d44745a
Compare
|
Rebased on origin/master |
2a8a45b to
514820b
Compare
|
|
|
660a4df to
406f399
Compare
|
Rebased on |
- For each detected asset, display its line number and header snippet for reference. - When asset data cannot be found or the number of values detected is incorrect, and inline error message is displayed instead of a (broken) asset editor.
align-items: flex-start
Use bpw or verilog spec to pad correct number of chars.
Do not treat a new asset block as the end of a previous block
Asset editor replaces text ranges instead of the entire source file. Undo inside the source code now scrolls asset editor edits into view, and selects the text being edited, so that what is being (un)edited is much clearer. Also, undo history is no longer burdened by full file edits.
Add calculation of maximum reachable offset. Fixes errors with `chr_generic.s`
Fix broken asset edit and undo when the asset source file has not been opened manually, for example when reloading the #asseteditor page directly.
- Track selected asset in hash - Highlight selected asset on navigation
|
Very cool! Glad to see Asset Editor getting some love. Lemme take a closer look at everything and merge soon. Have you been using it succesfully in your projects? |
|
Thanks. This PR was a bit of a treasure hunt adventure, to find all different things it supported across platforms. I've spent a fair bit of time with the undo/redo functionality, and how it interacts with editor edits. One design choice was that when you navigate to the asset editor its undo/redo stack is reset. That way extra undos from the user won't result in surprises (i.e. source code edits unrelated to the asset editor being undone and lost to the sands of time). Open to more ideas to improve the UX. Please feel free to change the CSS. I really like the filename pill at the top of the asset editor cards. I don't feel that my visual additions to the asset editor and text editor look as good as that aesthetic. |
|
Undo/redo resetting makes sense for this case, glad you figured it out. I'll go ahead and merge and any minor issues can be cleaned up later. Thanks! Looks good! |


Uh oh!
There was an error while loading. Please reload this page.