refactor(cli): unify block tree on HMBlockNode, fix markdown images#403
Open
refactor(cli): unify block tree on HMBlockNode, fix markdown images#403
Conversation
…solution Replace BlockNode with HMBlockNode throughout the diff engine and CLI pipeline. This eliminates the parallel type system and the bidirectional converters (hmBlockNodeToBlockNode, markdownBlockNodesToHMBlockNodes at call sites). - block-diff.ts: computeReplaceOps, matchBlockIds, isBlockContentEqual now accept HMBlockNode directly; removed hmBlockNodeToBlockNode - markdown-to-blocks.ts: parseMarkdown now returns HMBlockNode[] by calling markdownBlockNodesToHMBlockNodes internally - document.ts: markdown path now resolves file:// image links to IPFS via resolveFileLinks (previously only worked for JSON input) - Removed flattenToOperations usage in favor of hmBlockNodesToOperations - Updated all tests to use HMBlockNode format Fixes: markdown images with local file paths () are now uploaded to IPFS and rendered correctly when published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockNodewithHMBlockNodein the diff engine and CLI pipeline, eliminating the parallel type system and bidirectional converters) — they now resolve to IPFS automatically, same as JSON inputhmBlockNodeToBlockNodeand replacesflattenToOperationswithhmBlockNodesToOperations