Open
Conversation
bendo-eXX
force-pushed
the
fix/csaf-2.0_mandatory_test_6.1.26
branch
from
1ef107e to
abbdf2a
Compare
|
Coverage after merging fix/csaf-2.0_mandatory_test_6.1.26 into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rainer-exxcellent
changed the title
tschmidtb51
reviewed
Mar 11, 2026
Contributor
tschmidtb51
left a comment
tschmidtb51
left a comment
There was a problem hiding this comment.
Fix seems to be okay (didn't test it as I think you did that already) but incomplete. Also, it kind of doesn't fully implement what is stated by the text - so, I'm not yet sure that the implementation is actually structurally correct.
1. Regarding incomplete:
The text states:
Any occurrences of dash, white[]space, and underscore characters are removed from the values on both sides before the match.
CSAF 2.1 clarifies that a bit more, what is in those groups of characters - see 6.1.26
2. Regarding structurally correct:
I suggest to open a ticket for that and revisit that later. I have to rethink and discuss that again.
Suggestion (given the current situation):
Either
a) merge this and release (I guess that was the question), fix 1 and 2 later OR
b) fix 1 in this PR; 2 later.
Either way - as we fix 2 later, I'll review the whole test then again. So no need for me to review this PR again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix test for test case oasis_csaf_tc-csaf_2_0-2021-6-1-26-04.json