Fs 2.1.0 and workaround for takeThroughDrain#2
Closed
declspec-cdecl wants to merge 5 commits intosebastianvoss:fs2_1.0.4from
Closed
Fs 2.1.0 and workaround for takeThroughDrain#2declspec-cdecl wants to merge 5 commits intosebastianvoss:fs2_1.0.4from
declspec-cdecl wants to merge 5 commits intosebastianvoss:fs2_1.0.4from
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem with early-terminated.drain test with fs 2.x.x is that
.onFinalizeintakeThroughDrainexecuted after lastStream.eval(queue.dequeue1). I dont know why. I've not found answer even in fs2 gitter. Maybe it's a bug maybe it's a feature. But I've found workaround. If there is.onFinalize{IO.unit}after usage oftakeThroughDrainthen all goes as expected. This can be seen in scastie example. So I've fixed all tests and usages oftakeThroughDrainwith account of the workaround.