Fall back to select if poll does not exist#117
Open
jstasiak wants to merge 1 commit into
Open
Conversation
The explanation is in the comment in the code. Closes: seb-m#78
jstasiak
force-pushed
the
select-fallback
branch
from
b22f460 to
04fea85
Compare
This was referenced Jan 7, 2016
Closed
Author
|
@seb-m Is there something that remains to be done in order for this patch to get merged? Thanks in advance. |
|
👍 |
|
any expected date to do this merge? |
Author
|
@seb-m Do I need to do something more to get this merged? Thanks in advance. |
Author
|
Seeing as this repository seems to have been inactive lately we're likely to create a fork with this and some other pull requests merged. |
Author
|
Our fork can be found here: https://pypi.python.org/pypi/pyinotify-smarkets I'll leave this pull request open in case it gets a chance to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select.poll will be missing when Gevent (or Eventlet, soon) monkey patching is applied.
Closes: #78