refactor(playbooks): extract extra file upload logic into dedicated role#907
Open
insatomcat wants to merge 1 commit intomainfrom
Open
refactor(playbooks): extract extra file upload logic into dedicated role#907insatomcat wants to merge 1 commit intomainfrom
insatomcat wants to merge 1 commit intomainfrom
Conversation
Member
|
Code looks good to me, but that make a lot of duplication between all prerequisites |
Member
|
Also, for your information, we have re-enable yamllint in ansible-lint |
insatomcat
changed the title
Member
Author
|
I updated to a dedicated role. |
eroussy
previously approved these changes
Apr 2, 2026
Member
Yes indeed. It should be reactivated at the end of the afternoon |
Member
|
re-open to trigger CI |
eroussy
requested changes
Apr 2, 2026
Create a reusable `upload_extra_files` role and replace duplicated upload tasks in Debian, CentOS, Oracle Linux, and Yocto prerequisite playbooks. The role now ensures destination directories exist before `copy`/`unarchive` and includes defaults, metadata, and README. Signed-off-by: Florent Carli <florent.carli@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a reusable
upload_extra_filesrole and replace duplicated upload tasks in Debian,CentOS, Oracle Linux, and Yocto prerequisite playbooks. The role now ensures destination
directories exist before
copy/unarchiveand includes defaults, metadata, and README.