fix: stop padding rows to widest filename#113
Conversation
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 4 |
TIP This summary will be updated as you push new changes. Give us feedback
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 34 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughModified table border rendering configuration from generic borders to left border in the table utility. Added unit and integration tests to verify that filename rows with varying lengths are not automatically padded to match the longest filename in the table. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
This closes #58.
The change removes the fake right-hand space border from the shared
prettytableformat while keeping the existing left margin. That stopsprettytablefrom padding the final column in every row to the width of the longest filename.The underlying bug was that one oversized filename made every row wide enough to wrap at the terminal edge, which is why long and short listings both looked double-spaced. With the trailing border removed, genuinely long rows still wrap, but shorter rows stay single-spaced like native
ls.The PR also adds renderer and integration regressions for both long and short output so the padding behavior does not come back.
Summary by CodeRabbit
Release Notes
Bug Fixes
Tests