fix(v2): store registry credentials without nerdctl login#14
Merged
Conversation
Replace nerdctl login with direct docker config credential storage to avoid HTTPS registry auth failures when WWW-Authenticate omits :443 on port 443. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nerdctl loginin the v2 committer with direct credential storage viadockerconfigresolver.registerRegistryCredentialsthat also stores credentials for the host without:443when using standard HTTPS, matching nerdctl login behavior and avoiding WWW-Authenticate host/port mismatches on port 443.Test plan
go build ./internal/commit/...inv2/controllerWWW-AuthenticateMade with Cursor