fix(monitoring): allow Codex quota refresh without account id#87
Merged
Conversation
Extract shared Codex quota request, parsing, and rate-limit helpers. Move quota page and Codex inspection onto the shared path. Keeps existing behavior while reducing future drift across callers.
Remove the request monitoring hard failure when Codex credentials lack a ChatGPT account ID. Use the shared optional-header Codex quota request helper. Adds regression coverage for account-id-less Codex quota targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Codex quota refresh in request monitoring when credentials do not expose a ChatGPT account ID.
Cause
Request monitoring had a separate Codex quota request path that still required
chatgpt_account_id.Other quota paths had already made
Chatgpt-Account-Idoptional, so the behavior drifted.Solution
Chatgpt-Account-Id.Testing
npm test -- codexQuota accountOverviewQuotaTargets MonitoringCenterPagegit diff --checknpm run type-checkcurrently fails on existing missingreact-test-renderer/ type declarations in unrelated auth-file tests.