[codex] Add auth JSON paste import#68
Conversation
|
Thanks for the PR. The feature direction looks good, and the paste-based JSON import flow is useful. I’d suggest a few changes before merging:
Also, GitHub flags hidden/bidirectional Unicode in some changed files, so please clean those up before merging. Overall, I support the feature, but I’d request changes before merging. |
881a596 to
4234271
Compare
|
Hi, I addressed the requested auth JSON paste/import fixes and updated the PR branch. What changed:
Verification run after squashing to one commit:
I also squashed the branch down to a single commit for easier review: Please review again. From my side, there are no known blocking issues for merge. |
|
Thanks for the update. I rechecked the latest commit, and the implementation now addresses the main review points from my previous comment: no synthetic unsigned There are still two items to fix before merge:
Please regenerate/fix the lockfile, ideally with the CI Node/npm version, and push the updated package-lock.json. Suggested validation:
Once these are addressed and the Frontend check passes, I think this PR is close from the feature side. |
Add the auth JSON paste/import flow with converter hardening, provider-aware CPA validation, upload failure handling, duplicate-save guards, hidden Unicode checks, and focused regression coverage.
4234271 to
56552a7
Compare
|
Thanks, all configured checks are green now. The implementation looks good to me, and the previous auth-conversion concerns have been addressed. Since the current CI passes and there are no merge conflicts, I’m okay with merging this PR. One non-blocking follow-up: the frontend PR workflow currently runs type-check, lint, and build, but not |
|
Thanks for the review and merge. I’ll keep the npm test CI addition as a follow-up item. |
What changed
Adds a Paste JSON flow to the Auth Files page so users can create auth files without uploading a local file.
AuthJsonPasteModalwith auth type selection, file name validation, JSON textarea input, and save/error states.sessionAuthConverterto validate CPA auth JSON directly or convert ChatGPT Web session JSON into CPA Codex auth format.Why
Users may only have auth/session JSON copied from another source and should not need to create a temporary local file before importing it into CPA Manager.
Impact
The Auth Files page now has a
Paste JSONaction next to upload. CPA JSON is saved as-is after object validation. ChatGPT Web session JSON is converted into the CPA Codex auth shape before upload, including account identity, token fields, expiration, and a safe generated file name when the default name is used.Validation
npm test -- --run src/features/authFiles/sessionAuthConverter.test.tsnpm run build