Open
Conversation
Ivan-Velickovic
force-pushed
the
fix_assert_fail
branch
from
868b39c to
3b0f1cd
Compare
This is used by libsel4 headers, we should actually crash when an assert fails and also print out the name of the PD that failed. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
fix_assert_fail
branch
from
3b0f1cd to
605f02d
Compare
Ivan-Velickovic
changed the title
Collaborator
Author
|
I imagine this should also be a weakly declared function so users can override it? |
Contributor
Yes, likely. I think we've run into case before where libc wants to define this. We should probably also be consistent with our 'asserts' in the header files and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used by libsel4 headers, we should actually crash when an assert fails and also print out the name of the PD that failed.