Skip to content

[Composite primary keys] Validate parent primary key matches table primary key#2830

Merged
fealho merged 2 commits intofeature/metadata-composite-keysfrom
issue-composite-pks
Mar 3, 2026
Merged

[Composite primary keys] Validate parent primary key matches table primary key#2830
fealho merged 2 commits intofeature/metadata-composite-keysfrom
issue-composite-pks

Conversation

@fealho
Copy link
Copy Markdown
Member

@fealho fealho commented Feb 27, 2026

@sdv-team
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (273703c) to head (331fe2a).
⚠️ Report is 4 commits behind head on feature/metadata-composite-keys.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           feature/metadata-composite-keys    #2830      +/-   ##
===================================================================
- Coverage                            98.12%   98.11%   -0.02%     
===================================================================
  Files                                   73       73              
  Lines                                 8177     8174       -3     
===================================================================
- Hits                                  8024     8020       -4     
- Misses                                 153      154       +1     
Flag Coverage Δ
integration 75.51% <75.00%> (+<0.01%) ⬆️
unit 97.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho marked this pull request as ready for review February 27, 2026 15:30
@fealho fealho requested a review from a team as a code owner February 27, 2026 15:30
@frances-h
Copy link
Copy Markdown
Contributor

Can we point this change to the feature branch feature/metadata-composite-keys instead?

@fealho fealho changed the base branch from main to feature/metadata-composite-keys February 27, 2026 15:55
@fealho fealho merged commit 9703a32 into feature/metadata-composite-keys Mar 3, 2026
46 of 47 checks passed
@fealho fealho deleted the issue-composite-pks branch March 3, 2026 16:50
@fealho fealho added this to the 1.34.3 milestone Mar 3, 2026
@sarahmish sarahmish modified the milestones: 1.34.3, 1.34.4 Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants