Skip to content

Newbranch#3

Open
kokil87 wants to merge 8 commits intomasterfrom
newbranch
Open

Newbranch#3
kokil87 wants to merge 8 commits intomasterfrom
newbranch

Conversation

@kokil87
Copy link
Copy Markdown
Collaborator

@kokil87 kokil87 commented Dec 13, 2017

Created five pages using the bootstrap theme SB ADMIN-2

Copy link
Copy Markdown
Contributor

@c0dzilla c0dzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please point out the lines directly written by you

@kokil87
Copy link
Copy Markdown
Collaborator Author

kokil87 commented Dec 15, 2017

I have commented the html files which are in the pages folder as pls use "added" keyword to find the changes
Other relevant changes which I forgot:
changing class like push-left to push-right, changed the size of the cols such as col-lg-6 to 12 and few minor changes

Copy link
Copy Markdown
Contributor

@c0dzilla c0dzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go through the code and ensure proper indentation and line breaks. Remove unnecessary comments like I've pointed out. Good job!

Comment thread pages/Thread.html
<a href="4.html">4</a>
</li>
<li class="text-center relative">
<a href="6.html">5</a>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 5.html?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was just vague data i have added the data in newbranch -3 pull req #4

Comment thread pages/Thread.html




Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uniform indentation improves code readability.Try to have uniform indentation. Remove all unnecessary line breaks.

Comment thread pages/Thread.html
</div>
<!-- /.col-lg-4 -->
</div>
<div class="col-lg-12"> <!--Added several changes in the discussion box-->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment and other such unnecessary ones. Though commenting is a good practice :)

Comment thread pages/Thread.html
</div>
</div>
</li>
<li><div class="extraspace"></div></li> <!--extra space added-->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants