[WIP] First draft of SlimmableWavenet#243
Merged
sdatkinson merged 3 commits intosdatkinson:mainfrom Mar 13, 2026
Merged
Conversation
jfsantos
force-pushed
the
feature/slimmable-wavenet
branch
from
cd48815 to
d513ef1
Compare
Owner
|
I haven't looked at the implementation yet but I'm going to pre-empt that we may be able to make use of numerical integration tests (see Atkinson-Advanced-Modeling/NamIntegrationTests#2) to ensure that the results are as we need them to be. I'll keep that in mind as I review--let's PR checks there next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a big one. Most of the logic is behind parsing the weights to slim the model according to the config. Might be interesting to add a test to compare a non-slimmable model with a slimmed model where both have the same parameters and make sure they match, but I haven't done that yet. Submitting the PR just so you can get a head start on checking the API and the logic.
Developed with support and sponsorship from TONE3000