Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 90.98% 91.47% +0.48%
==========================================
Files 11 10 -1
Lines 1797 1759 -38
==========================================
- Hits 1635 1609 -26
+ Misses 162 150 -12
🚀 New features to boost your workflow:
|
MuData/AnnData read from Zarr cannot be backed, so there is no need for custom handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to AnnData's public API as much as possible.
I was hoping to be able to get rid of most of our custom implementations and just use
read_elemfor everything, but unfortunately that is not possible:read_elemdoes not handle backed mode and AnnData'sread_h5adonly supports file paths, not opened files/groups.write_dataargument which is not supported by AnnData. This was presumably introduced as an analog to_write_h5mu'swrite_data. However, the_write_h5muwrite_dataargument is required for handling backed h5mu files inMuData.write_h5mu. Zarr files cannot be backed, so that argument is presumably not needed and can be removed.