fix(3433): prevent workflow graph render crashes from edges referencing missing nodes#1568
Merged
fix(3433): prevent workflow graph render crashes from edges referencing missing nodes#1568
Conversation
minghay
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Some workflow graphs can include edges whose src or dest does not exist in nodes.
This can happen because of upstream workflowGraph generation issues, including the known case tracked in screwdriver-cd/screwdriver#3206.
When that data reaches the UI, graph decoration can leave those edges without usable coordinates, and the workflow graph rendering may fail at draw time.
Objective
This PR makes workflow graph rendering resilient to edges that reference missing nodes.
Intentional changes:
References
screwdriver-cd/screwdriver#3433
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.