Skip to content

fix(3433): repeated coverage info requests in jobs table#1566

Merged
minghay merged 2 commits intomasterfrom
job-list-view-coverage
Mar 31, 2026
Merged

fix(3433): repeated coverage info requests in jobs table#1566
minghay merged 2 commits intomasterfrom
job-list-view-coverage

Conversation

@yk634
Copy link
Copy Markdown
Contributor

@yk634 yk634 commented Mar 24, 2026

Context

The jobs table was repeatedly calling the coverage info API when rows were re-rendered or shown again after sorting and pagination changes.
As a result, the UI sent duplicate requests for coverage data that had already been requested in the browser.

While making this change, lint errors were also surfaced in the same shuttle service area. Those issues are not the root cause of the coverage behavior, but they are fixed here as related cleanup in the touched code.

Objective

This PR reduces unnecessary coverage API traffic by reusing previously requested coverage data.

Intentional changes in this PR:

  • route jobs table coverage fetching through the shuttle service
  • cache successful coverage responses by request key
  • deduplicate in-flight requests for the same coverage request
  • allow the same coverage request to be retried after a failed response
  • fix lint issues in the touched shuttle service code path
    • parameter ordering fixes in app/shuttle/service.js for fetchFrom, fetchFromApi, and fetchFromStore

References

screwdriver-cd/screwdriver#3433

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@minghay minghay merged commit 459f0ff into master Mar 31, 2026
2 checks passed
@minghay minghay deleted the job-list-view-coverage branch March 31, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants