Skip to content

fix(3433): limit bulk job selection to visible rows in settings tables#1562

Merged
minghay merged 2 commits intomasterfrom
table-all-select
Mar 31, 2026
Merged

fix(3433): limit bulk job selection to visible rows in settings tables#1562
minghay merged 2 commits intomasterfrom
table-all-select

Conversation

@yk634
Copy link
Copy Markdown
Contributor

@yk634 yk634 commented Mar 19, 2026

Context

Bulk actions in the pipeline settings tables were selecting jobs outside the current filtered view.

When users enabled multi-select in the Jobs, Cache, or Metrics settings tables and clicked the header checkbox, the selection could include rows that were not currently visible after search or filtering.

Example: Although only 4 results are displayed after filtering, 18 items have been selected.
image

In addition, after running a bulk action such as Disable Jobs or Clear Cache, the table could retain stale internal selection state, causing a later single-row selection to behave as if the previous "select all" state was still active.

Objective

This PR updates the pipeline settings tables to make bulk selection behave consistently with what is currently displayed to the user.

The changes in this PR:

  • limit bulk selection in the Jobs, Cache, and Metrics settings tables to rows visible on the current filtered page
  • extract the visible-row calculation into a shared helper to avoid duplicated logic
  • reset table selection state after bulk actions so stale "select all" state does not affect later row selections

References

screwdriver-cd/screwdriver#3433

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@minghay minghay merged commit 41cbed2 into master Mar 31, 2026
2 checks passed
@minghay minghay deleted the table-all-select branch March 31, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants