particle fixes and subsystem speedup#7271
Merged
Goober5000 merged 1 commit intoscp-fs2open:masterfrom Mar 9, 2026
Merged
Conversation
Goober5000
added
fix
Goober5000
force-pushed
the
particle_fixes
branch
2 times, most recently
from
d0f7a0b to
d94e869
Compare
1. Modify `ship_get_subsys_for_submodel` to use the subsystem indexer. This changes the operation from O(n) to O(1) and also allows the function to work with turret gun barrels. 2. Add an `isValid` check to `ParticleSource::finishCreation` to prevent unknown state from being accessed if the source is not valid. 3. Tweak `EffectHostTurret` and make sure it works for fighter beams. 4. Prevent `createOnTurret` from running on submodels that are not turrets.
Goober5000
force-pushed
the
particle_fixes
branch
from
d94e869 to
89e7fd9
Compare
BMagnu
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ship_get_subsys_for_submodelto use the subsystem indexer. This changes the operation from O(n) to O(1) and also allows the function to work with turret gun barrels.isValidcheck toParticleSource::finishCreationto prevent unknown state from being accessed if the source is not valid.EffectHostTurretand make sure it works for fighter beams.This should fix all of the beam particle issues discovered by Star Fox: Event Horizon.