Merged
Conversation
Needed for new lookup table error masking.
nvaytet
approved these changes
Mar 16, 2026
Comment on lines
+96
to
+97
| " detector: EmptyDetector[RunType],\n", | ||
| " data: NeXusData[snx.NXdetector, RunType],\n", |
Member
There was a problem hiding this comment.
Weird diff? (also in the rest of the file)
Member
Author
There was a problem hiding this comment.
I guess ruff ran on the file automatically at some point. Should I revert?
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "workflow.visualize(TimeOfFlightLookupTable, graph_attr={\"rankdir\": \"LR\"})" |
Member
There was a problem hiding this comment.
Note that these changes are fine, but the name TimeOfFlightLookupTable (which is now an alias) should still be available?
Member
Author
There was a problem hiding this comment.
Do we want to keep both names indefinitely? I figured I'd change it now so that we have a simpler interface.
Member
There was a problem hiding this comment.
Sure. Note that the name will change again with scipp/ess#65 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new error-limited lookup table. There is a complication from mapping over detectors, the default detector lut provider depends on the detector name. But the tof conversion happens after collecting the detector banks into a single data array. So the sciline map fails. We have two options here:
I went with 2 and hard-coded the name 'detector'. This threshold is applied to all banks. This is probably fine because the path lengths are all similar. But maybe we could tune this a little better with per bank thresholds.