ci: split deploy-pages workflow into build and deploy jobs#378
Merged
Conversation
Separate the monolithic build-and-deploy job into two jobs with an artifact between them. The build job only needs contents: read permissions, while the deploy job has pages: write and id-token: write permissions and is protected by a github-pages environment. This follows the principle of least privilege and protects the deploy environment. Assisted-by: OpenCode:glm-5
Add pull_request trigger so the build job runs on PRs too. Gate the deploy job with `if: github.event_name == 'push'` so it only runs when pushing to main, not on PRs. Assisted-by: OpenCode:glm-5
zizmor requires undocumented-permissions to have comments. Assisted-by: OpenCode:glm-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Human guided, AI assisted PR (using this skill). AI text below. 🤖
Separate the monolithic
build-and-deployjob into two jobs with an artifact between them:contents: readpermission — checks out code, installs deps, builds the webapp, and uploads the pages artifactpages: writeandid-token: writepermissions, protected by agithub-pagesenvironment — configures pages and deploysThis follows the principle of least privilege by reducing the build environment's permissions and protects the deploy environment.
Assisted-by: OpenCode:glm-5