enhanced error handling for open weather API errors by anveshthakur · Pull Request #192 · schachmat/wego

anveshthakur · 2024-09-28T18:08:35Z

Motivation and Context

This change was requested in this issue #176

Description

I've handled error and success case that is coming from open weather API where I am checking the response code from the API and then printing it to the terminal, The marshalling was not happening because API sends Code as a string value for some of cases but if there is an invalid API key they send Code value is coming as an integer value I've handled this and just checking the type and marshalling it to a new struct called openWeatherErrorResponse

Steps for Testing

To test we can check different API responses like -

Invalidate API key
Invalidate the open weather API
For success case everything should work like it used be.

Screenshots

Invalid API key

Invalid API route

Success

anveshthakur · 2024-09-28T18:10:06Z

Hi @kordianbruck, Let me know if any changes are required required. Thanks!

Bug fix for issue schachmat#170 Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>

Current openweather api usage does not have daily astronomy. Api "onecall" seems to have. Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>

compacts the table and hides cloud icons

backends/openweathermap.org.go

Bumps [github.com/mattn/go-colorable](https://github.com/mattn/go-colorable) from 0.1.13 to 0.1.14. - [Commits](mattn/go-colorable@v0.1.13...v0.1.14) --- updated-dependencies: - dependency-name: github.com/mattn/go-colorable dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Agent-Logs-Url: https://github.com/schachmat/wego/sessions/e7020400-10d3-4119-8c62-9806e4de0ef2 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com>

* Add explicit import aliases for go-runewidth and go-colorable Agent-Logs-Url: https://github.com/schachmat/wego/sessions/0c63b2e2-efeb-44a9-a918-f4e769258361 Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Fix all golangci-lint issues across frontends and backends Agent-Logs-Url: https://github.com/schachmat/wego/sessions/0c63b2e2-efeb-44a9-a918-f4e769258361 Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Update golangci-lint version to v1.64 for Go 1.22+ compatibility Agent-Logs-Url: https://github.com/schachmat/wego/sessions/2043283b-a184-4384-8ee7-6a89926c0b1d Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Update golangci-lint to v2.11.4 to fix Go 1.26 stdlib typecheck error Agent-Logs-Url: https://github.com/schachmat/wego/sessions/de01a58a-38b0-4e37-9ac5-b4518d017a90 Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Upgrade golangci-lint-action to version 7 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> Co-authored-by: Kordian Bruck <kordianbruck@users.noreply.github.com>

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 9. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v9) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/mattn/go-runewidth](https://github.com/mattn/go-runewidth) from 0.0.16 to 0.0.20. - [Commits](mattn/go-runewidth@v0.0.16...v0.0.20) --- updated-dependencies: - dependency-name: github.com/mattn/go-runewidth dependency-version: 0.0.20 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

The endpoints as of 2026-04-04 appear to be: free/v2 => premium/v1 (still free) documented here https://github.com/WorldWeatherOnline/weather-api-docs also, move the debug request print to where it will actually happen on request fail

Co-authored-by: 0x0003 <0x0003@users.noreply.github.com>

* Initial plan * Add man page generation via mango with --man flag Agent-Logs-Url: https://github.com/schachmat/wego/sessions/00705e77-602c-4b73-9fda-139ce74cce3a Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com>

…mat#223) * Initial plan * Implement disk-based JSON caching in /tmp to reduce API calls Agent-Logs-Url: https://github.com/schachmat/wego/sessions/685ebab8-b98c-481c-9089-79312dba6748 Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com>

kordianbruck · 2026-04-11T21:18:40Z

Could you rebase this PR please?

* Add weatherapi.com backend and update README Agent-Logs-Url: https://github.com/schachmat/wego/sessions/823f57c2-2b5e-4347-962b-f80083b3332d Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Fix API key exposure in error/debug log messages Agent-Logs-Url: https://github.com/schachmat/wego/sessions/823f57c2-2b5e-4347-962b-f80083b3332d Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Fix CodeQL taint: build safe URL without using apiKey Agent-Logs-Url: https://github.com/schachmat/wego/sessions/823f57c2-2b5e-4347-962b-f80083b3332d Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Remove redundant parentheses in address-of expressions Agent-Logs-Url: https://github.com/schachmat/wego/sessions/823f57c2-2b5e-4347-962b-f80083b3332d Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> * Fix lint issues: lowercase error strings and check Body.Close error Agent-Logs-Url: https://github.com/schachmat/wego/sessions/505f0e3a-aa82-4117-b571-e1309ed9dcf8 Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kordianbruck <298860+kordianbruck@users.noreply.github.com>

anveshthakur · 2026-04-11T21:54:44Z

Could you rebase this PR please?

sure.

kordianbruck · 2026-04-11T22:08:42Z

Something really went wrong in that merge resolve/rebase.

anveshthakur · 2026-04-11T22:09:46Z

Something really went wrong in that merge resolve/rebase.

checking.

anveshthakur · 2026-04-11T22:23:57Z

Something really went wrong in that merge resolve/rebase.

Hey @kordianbruck, Let me create a fresh PR for this.
This is all messed up.

#227

enhanced error handling for openweathermap api errors

2e15d5e

peter81git and others added 3 commits October 6, 2024 18:42

Remove º from Kelvin temperature (schachmat#189)

75ab651

Bug fix for issue schachmat#170 Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>

Openmeteo correction for daily astronomy. (schachmat#190)

2127ad0

Current openweather api usage does not have daily astronomy. Api "onecall" seems to have. Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>

compact mode for aat (schachmat#191)

6578d5e

compacts the table and hides cloud icons

kordianbruck requested changes Oct 6, 2024

View reviewed changes

backends/openweathermap.org.go Outdated Show resolved Hide resolved

backends/openweathermap.org.go Outdated Show resolved Hide resolved

backends/openweathermap.org.go Outdated Show resolved Hide resolved

anveshthakur and others added 13 commits October 7, 2024 00:09

changed Cod to Code and removed the extra else from fetch fn

eb56ff3

changed the Cod to Code from Unmarshal fn

fdb55e2

Query openweathermap API over https (schachmat#207)

544facc

Co-authored-by: 0x0003 <0x0003@users.noreply.github.com>

Copilot AI and others added 2 commits April 11, 2026 23:23

Render Wind, Rain and Visibility in Markdown frontend

b136770

anveshthakur added 4 commits April 12, 2026 03:34

enhanced error handling for openweathermap api errors

f5320a2

changed Cod to Code and removed the extra else from fetch fn

7a38e01

changed the Cod to Code from Unmarshal fn

b3a894f

resolves conflict

bd3d4eb

kordianbruck closed this Apr 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhanced error handling for open weather API errors#192

enhanced error handling for open weather API errors#192
anveshthakur wants to merge 23 commits intoschachmat:masterfrom
anveshthakur:feat/api-errors

anveshthakur commented Sep 28, 2024 •

edited by kordianbruck

Loading

Uh oh!

anveshthakur commented Sep 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kordianbruck commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

kordianbruck commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

anveshthakur commented Sep 28, 2024 • edited by kordianbruck Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Steps for Testing

Screenshots

Invalid API key

Invalid API route

Success

Uh oh!

anveshthakur commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kordianbruck commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

kordianbruck commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

anveshthakur commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anveshthakur commented Sep 28, 2024 •

edited by kordianbruck

Loading

anveshthakur commented Sep 28, 2024 •

edited

Loading