CLDSRV-839: Multi delete raftSession in logs by BourgoisMickael · Pull Request #6061 · scality/cloudserver

BourgoisMickael · 2026-01-26T20:53:17Z

Include raft in server access logs
Replace REST.POST.OBJECT => REST.POST.MULTI_OBJECT_DELETE
Add internal BATCH.DELETE.OBJECT lines for each key

bert-e · 2026-01-26T20:53:20Z

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2026-01-26T20:54:10Z

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (70af4b6) to head (86d9120).
⚠️ Report is 12 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/utilities/serverAccessLogger.js	96.66%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/multiObjectDelete.js	`80.65% <100.00%> (+0.58%)`	⬆️
lib/metadata/metadataUtils.js	`90.90% <ø> (ø)`
lib/utilities/serverAccessLogger.js	`78.86% <96.66%> (+2.12%)`	⬆️

@@                 Coverage Diff                 @@
##           development/9.2    #6061      +/-   ##
===================================================
+ Coverage            84.41%   84.44%   +0.02%     
===================================================
  Files                  206      206              
  Lines                13038    13068      +30     
===================================================
+ Hits                 11006    11035      +29     
- Misses                2032     2033       +1

Flag	Coverage Δ
file-ft-tests	`67.53% <90.24%> (+0.05%)`	⬆️
kmip-ft-tests	`28.06% <26.82%> (-0.04%)`	⬇️
mongo-v0-ft-tests	`68.76% <90.24%> (+0.02%)`	⬆️
mongo-v1-ft-tests	`68.77% <90.24%> (+0.04%)`	⬆️
multiple-backend	`35.34% <26.82%> (-0.06%)`	⬇️
sur-tests	`35.63% <73.17%> (+0.07%)`	⬆️
sur-tests-inflights	`37.44% <73.17%> (+0.04%)`	⬆️
unit	`69.89% <58.53%> (-0.06%)`	⬇️
utapi-v2-tests	`34.34% <73.17%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Each key in a multi object delete has a line in logs This line should be filtered out of access_logs for cloudserver aggregated table in s3 analytics

- time fields (elapsed_ms, totalTime) - requestURI

leif-scality · 2026-01-28T09:22:31Z

                });
+                // Log successful deletion with object size
+                const objectSize = objMD && objMD['content-length'] ? objMD['content-length'] : null;
+                logBatchDeleteObject(request, requestID, entry.key, objectSize, null);


The log should be done in onFinish in server.js for the timers to be correct.

internal requests (both batch delete and REST.COPY.*_GET doesn't hold any timing information

But maybe instead of logging immediately I could store the objects and queue them in memory to log everything at the end with this regular log. But that would put a little more memory usage

Change the behavior to queue each internal request to log them at the end of request: f7a31fb

bert-e · 2026-01-28T10:16:50Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

To be written after request finish. There can be up to 1000 items in queue during request. Memory usage should be limited

BourgoisMickael · 2026-01-28T17:05:27Z

/approve

bert-e · 2026-01-28T17:05:41Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-839-multidelete-logs into
development/9.2
w/9.3/bugfix/CLDSRV-839-multidelete-logs will be merged into development/9.3

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2026-01-28T17:28:10Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.2
✔️ development/9.3

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2026-01-28T17:50:28Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2026-01-28T18:57:36Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.2
✔️ development/9.3

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

Please check the status of the associated issue CLDSRV-839.

Goodbye bourgoismickael.

BourgoisMickael added 3 commits January 26, 2026 20:57

CLDSRV-839: Multi delete raftSession in logs

5033151

CLDSRV-839: Fix REST.POST.MULTI_OBJECT_DELETE logs

d095fe9

CLDSRV-839: Test raft session id presence metadata

ec55c0e

BourgoisMickael force-pushed the bugfix/CLDSRV-839-multidelete-logs branch 10 times, most recently from 0843e4b to 9c6c2be Compare January 28, 2026 04:07

BourgoisMickael added 4 commits January 28, 2026 05:41

CLDSRV-839: Add BATCH.DELETE.OBJECT lines

8c7f976

Each key in a multi object delete has a line in logs This line should be filtered out of access_logs for cloudserver aggregated table in s3 analytics

CLDSRV-839: optional fields for batch delete

ae1905e

- time fields (elapsed_ms, totalTime) - requestURI

CLDSRV-839: Make a function for validation

9e88ae6

CLDSRV-839: Check BATCH.DELETE.OBJECT unordered

76c80d4

BourgoisMickael force-pushed the bugfix/CLDSRV-839-multidelete-logs branch from 9c6c2be to 76c80d4 Compare January 28, 2026 04:41

BourgoisMickael requested a review from a team January 28, 2026 05:39

leif-scality reviewed Jan 28, 2026

View reviewed changes

BourgoisMickael requested a review from a team January 28, 2026 11:01

scality deleted a comment from leif-scality Jan 28, 2026

CLDSRV-839: Queue internal log request

f7a31fb

To be written after request finish. There can be up to 1000 items in queue during request. Memory usage should be limited

BourgoisMickael requested review from a team, dvasilas and leif-scality and removed request for a team January 28, 2026 14:35

BourgoisMickael requested a review from fredmnl January 28, 2026 14:35

dvasilas approved these changes Jan 28, 2026

View reviewed changes

Comment thread lib/utilities/serverAccessLogger.js Outdated

BourgoisMickael requested review from a team and anurag4DSB and removed request for a team January 28, 2026 15:31

scality deleted a comment from bert-e Jan 28, 2026

BourgoisMickael requested review from jonathan-gramain, tcarmet and tmacro January 28, 2026 16:28

tcarmet approved these changes Jan 28, 2026

View reviewed changes

CLDSRV-839: Don't export fct logBatchDeleteObject

86d9120

scality deleted a comment from bert-e Jan 28, 2026

bert-e merged commit 8606a3a into development/9.2 Jan 28, 2026
29 checks passed

bert-e deleted the bugfix/CLDSRV-839-multidelete-logs branch January 28, 2026 18:57

Conversation

BourgoisMickael commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Jan 26, 2026

Hello bourgoismickael,

Uh oh!

codecov Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

leif-scality Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bert-e commented Jan 28, 2026

Request integration branches

Uh oh!

Uh oh!

BourgoisMickael commented Jan 28, 2026

Uh oh!

bert-e commented Jan 28, 2026

Integration data created

Uh oh!

bert-e commented Jan 28, 2026

In the queue

Uh oh!

bert-e commented Jan 28, 2026

Queue build failed

Uh oh!

bert-e commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BourgoisMickael commented Jan 26, 2026 •

edited

Loading

codecov Bot commented Jan 26, 2026 •

edited

Loading