Fix for issue #68 with title and message text alignment#118
Open
funnel20 wants to merge 2 commits intoscalessec:masterfrom
Open
Fix for issue #68 with title and message text alignment#118funnel20 wants to merge 2 commits intoscalessec:masterfrom
funnel20 wants to merge 2 commits intoscalessec:masterfrom
Conversation
* The key it to use the same width for both UILabels. This will be the largest value of the 2 expected widths based on the text content. * The available width for the UILabel was too large; the style.horizontalPadding wasn't respected.
Author
|
@scalessec Hi, any reaction would be appreciated. It would be a shame when my similar solution as @shidelinFYH provided 2 years ago (see: |
Author
|
Hello? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves issue #68 with title and message alignment:
style.horizontalPaddingwasn't respected.Here is the before (left) and after (right) when using
style.titleAlignment = NSTextAlignmentCenter;:It also solves a problem that the UILabel is not resizing when using
horizontalPadding: