Add optional check_finite flag to process_x#1828
Open
patelshivani2283-lab wants to merge 2 commits intosbi-dev:mainfrom
Open
Add optional check_finite flag to process_x#1828patelshivani2283-lab wants to merge 2 commits intosbi-dev:mainfrom
patelshivani2283-lab wants to merge 2 commits intosbi-dev:mainfrom
Conversation
Contributor
Author
|
This is an initial step toward #1717. I can extend this to propagate the flag through posterior classes if needed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
- Coverage 88.54% 86.31% -2.23%
==========================================
Files 137 143 +6
Lines 11515 17753 +6238
==========================================
+ Hits 10196 15324 +5128
- Misses 1319 2429 +1110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
check_finiteargument toprocess_x.By default it is set to
True, so the existing behavior stays the same.If set to
False, it skips the NaN/Inf check (assert_all_finite).This can be useful in cases where the data is already validated and the extra check is not needed.