Learn and Clean (WIP) /!\ Please, don't merge or close yet#1
Open
sapereau83 wants to merge 5 commits intosavemysmartphone:masterfrom
Open
Learn and Clean (WIP) /!\ Please, don't merge or close yet#1sapereau83 wants to merge 5 commits intosavemysmartphone:masterfrom
sapereau83 wants to merge 5 commits intosavemysmartphone:masterfrom
Conversation
test regexps until end of string instead of end of line + specs. use Hash::try_convert for code readability. fix some norm issue.
sapereau83
force-pushed
the
read-and-fix
branch
from
19c414c to
103c328
Compare
sapereau83
changed the title
sapereau83
force-pushed
the
read-and-fix
branch
from
ff78033 to
f569987
Compare
Author
There was a problem hiding this comment.
this = selfSomeone gonna die soon..
TO BE CONTINUED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first look to the gem to familiarize with source code and get a global idea of the "Behind the scene".
BTW, I also clean what I can on the way ;)