Conversation
Refactor ProcessParser.start_messages() to build a message-id lookup table once instead of rescanning all BPMN message nodes for each message start event. This preserves the existing behavior while reducing the lookup path from O(m*n) to O(m+n), where m is the number of messages and n is the number of message start events. Add a focused regression test that counts id lookups so the improvement is verified without relying on noisy timing assertions.
Collapse repeated BPMN parser XPath scans into document- and process-level indexes while preserving existing parser behavior. This adds one-time indexes for messages, signals, errors, escalations, correlations, outgoing flows, boundary events, task nodes, data references, and BPMN DI lane/position metadata, and avoids fallback root scans when indexed absence is already known. Focused BPMN parser tests pass, and the full suite passed in both serial and parallel runs (681 tests, 1 skipped). On a large production workflow set of about 1.4 MB of BPMN/DMN XML, specs_from_xml improved from roughly 1.0s before this indexing work to a 10-run median of 0.195s, with a 0.161s minimum and 0.208s mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse repeated BPMN parser XPath scans into document- and process-level indexes while preserving existing parser behavior. This adds one-time indexes for messages, signals, errors, escalations, correlations, outgoing flows, boundary events, task nodes, data references, and BPMN DI lane/position metadata, and avoids fallback root scans when indexed absence is already known.
Focused BPMN parser tests pass, and the full suite passed in both serial and parallel runs (681 tests, 1 skipped). On a large production workflow set of about 1.4 MB of BPMN/DMN XML, specs_from_xml improved from roughly 1.0s before this indexing work to a 10-run median of 0.195s, with a 0.161s minimum and 0.208s mean.