NetApp replica create for flexgroup share error#310
Open
skook1 wants to merge 1 commit into
Open
Conversation
skook1
requested review from
Carthaca,
chuan137,
crenduchinta88,
kpawar-sap and
sumitarora2786
as code owners
Author
|
Not tested yet |
- added _wait_for_efficiency_job method which wait for efficiency async job to complete, if job_id exist Closes-Bug: #2143199 Change-Id: I4a9983da34ce54607bf206b8b175f0f59fbe413c
skook1
force-pushed
the
fix/netapp-replica-create-for-flexgroup-share-error
branch
from
e41c819 to
322309f
Compare
|
while creating PR make please changes in both cmode and cmode_rest, so that branch upgrade would be easy to pick commit rather than modify. |
Author
I think REST API already had this logic, you can check it here: manila/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py Lines 199 to 202 in c171e43 |
Collaborator
|
Can you please paste the link the upstream gerrit review? I think it is okay to wait for the fix the merge there, first, before we add it here. Change itself lgtm |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes-Bug: #2143199
Change-Id: I4a9983da34ce54607bf206b8b175f0f59fbe413c