NetApp: reuse TLS session, reconnect on failure#308
Open
chuan137 wants to merge 1 commit into
Open
Conversation
_refresh_conn was never reset to False after _build_session(), causing every invoke_elem() call to create a new requests.Session() with a full TCP+TLS handshake (3-4 RTTs) instead of reusing the existing connection (1 RTT). Confirmed via py-spy on qa-de-1 (5 concurrent share creations, 60s flame graph): ssl_wrap_socket dropped from 45% to 33% of samples after fix.
chuan137
requested review from
Carthaca,
crenduchinta88,
kpawar-sap and
sumitarora2786
as code owners
chuan137
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_refresh_conn was never reset to False after _build_session(), causing
every invoke_elem() call to create a new requests.Session() with a full
TCP+TLS handshake (3-4 RTTs) instead of reusing the existing connection
(1 RTT).
Confirmed via py-spy on qa-de-1 (5 concurrent share creations, 60s
flame graph): ssl_wrap_socket dropped from 45% to 33% of samples after
fix.