Skip to content

Add pytz dependency to test requirements#32

Closed
rajivmucheli wants to merge 2 commits intostable/2025.2-m3from
rajivmucheli-patch-1
Closed

Add pytz dependency to test requirements#32
rajivmucheli wants to merge 2 commits intostable/2025.2-m3from
rajivmucheli-patch-1

Conversation

@rajivmucheli
Copy link
Copy Markdown

required for audit-middleware

@notque notque self-requested a review January 13, 2026 05:10
Copy link
Copy Markdown

@notque notque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@joker-at-work joker-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think requirements are installed in tests, too, so this means duplication.

If barbican doesn't need this, it shouldn't be part of barbican's requirements.txt. You could use our internal custom-requirements.txt but really, it should be part of audit-middleware's requirements.txt. afaik, lower-constraints.txt are not evaluated to get a list of packages to install when finding dependencies, so audit-middleware needs to properly define their dependencies. lower-constraints.txt are afaik also only evaluated when explicitly passed as contraint file to pip - which is not how we install audit-middleware in our images.

@rajivmucheli
Copy link
Copy Markdown
Author

I think requirements are installed in tests, too, so this means duplication.

If barbican doesn't need this, it shouldn't be part of barbican's requirements.txt. You could use our internal custom-requirements.txt but really, it should be part of audit-middleware's requirements.txt. afaik, lower-constraints.txt are not evaluated to get a list of packages to install when finding dependencies, so audit-middleware needs to properly define their dependencies. lower-constraints.txt are afaik also only evaluated when explicitly passed as contraint file to pip - which is not how we install audit-middleware in our images.

Hi @notque, could you implement the above ? i will close this PR then.

@notque
Copy link
Copy Markdown

notque commented Jan 13, 2026

Thanks @joker-at-work - replaced with sapcc/openstack-audit-middleware#129

@notque notque closed this Jan 13, 2026
@notque notque deleted the rajivmucheli-patch-1 branch January 13, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants