Skip to content

[ux] Handle pipeline name request edge cases#2743

Merged
StephenHulme merged 5 commits intodevelopfrom
sh51/add-more-use-cases-for-requests
Mar 18, 2026
Merged

[ux] Handle pipeline name request edge cases#2743
StephenHulme merged 5 commits intodevelopfrom
sh51/add-more-use-cases-for-requests

Conversation

@StephenHulme
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme commented Mar 13, 2026

Closes missing pipeline name on transitional purposes, alternative to #2737.

Screenshot 2026-03-10 at 11 44 56

Changes proposed in this pull request

  • determine pipeline groups from subsets of criteria
  • refactor pipeline info presenter

After screenshots:

Screenshot 2026-03-13 at 09 40 28 Screenshot 2026-03-13 at 09 40 43 Screenshot 2026-03-13 at 09 41 28 Screenshot 2026-03-13 at 09 42 38

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.93%. Comparing base (78f5d04) to head (45e147f).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2743   +/-   ##
========================================
  Coverage    84.93%   84.93%           
========================================
  Files          501      501           
  Lines        20598    20600    +2     
  Branches       377      377           
========================================
+ Hits         17495    17497    +2     
  Misses        3100     3100           
  Partials         3        3           
Flag Coverage Δ
javascript 80.25% <ø> (ø)
pull_request 84.93% <100.00%> (+<0.01%) ⬆️
push 84.93% <100.00%> (-0.01%) ⬇️
ruby 92.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme self-assigned this Mar 13, 2026
Copy link
Copy Markdown
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!


# Find intersection if possible
intersected_all_groups = all_groups.reduce(&:&)
intersected_purpose_filters = purpose_filter_groups.reduce(&:&)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does &:& do out of interest?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returns intersection of all elements

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be a rubocop or copilot trick... thanks for looking it up, I'll add a comment!

@StephenHulme StephenHulme merged commit 7eb0768 into develop Mar 18, 2026
14 checks passed
@StephenHulme StephenHulme deleted the sh51/add-more-use-cases-for-requests branch March 18, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants