add CPU-level parallelism for computing binary diffs#39
Open
slingamn wants to merge 2 commits intosanbornm:masterfrom
Open
add CPU-level parallelism for computing binary diffs#39slingamn wants to merge 2 commits intosanbornm:masterfrom
slingamn wants to merge 2 commits intosanbornm:masterfrom
Conversation
Wait for all updates to be successfully processed before updating the file containing the latest version number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some rudimentary testing of this --- used it on different versions of a Go executable I'm familiar with, verified that nothing crashed, that the expected files were produced, and that the expected level of parallelism was achieved. Let me know if you want me to do further testing.
Thanks for this project! I was resistant to the idea at first but it works great. #13 was very useful.