Feature/component monitoring#118
Closed
patrick-skowronek wants to merge 5 commits intomainfrom
Closed
Conversation
TKussel
requested changes
Sep 5, 2023
Member
TKussel
left a comment
There was a problem hiding this comment.
In the BBMRI case, the monitoring app is not added to the Beam-Proxy apps.
The Monitoring components for both projects are missing a container_name directive
Sidenote: Please ensure, that your application can deal with a delayed-started beam Proxy. depends_on is not sufficient, as the container might be running but the Beam Proxy not yet fully operational.
TKussel
approved these changes
Sep 7, 2023
Member
|
I made sure that this component is very silent on startup when it is not able to reach the proxy yet. No beam-connect type of endless retrying spamming the logs. |
lablans
requested changes
Oct 6, 2023
Member
lablans
left a comment
There was a problem hiding this comment.
Also, before we merge, we need to communicate these changes in the individual projects
Co-authored-by: Martin Lablans <6804500+lablans@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the bridgehead monitoring component.
It allows Monitoring tools like icinga2 to check running component.