fix: bump initial commit #3
Open
kszinhu wants to merge 3 commits intosaleszera:mainfrom
Open
Conversation
Changes: * Add x86_64-linux platform to Gemfile.lock
Changes: * Added a check for required attributes (`id`, `thread_id`, `created_at`) in `Thread::Item.from_event`, raising an `ArgumentError` if any are missing. * Made the `parse_workflow_data` method in `Thread::Item` a class method and updated its usage accordingly for clarity and correctness. * Added a `client` reader attribute to `Session` for easier access to the `ChatKit` client instance.
saleszera
requested changes
Dec 5, 2025
Owner
saleszera
left a comment
saleszera
left a comment
There was a problem hiding this comment.
Your fix is great overall, but there are some points that we need to discuss
Comment on lines
+81
to
+84
| missing_attrs = REQUIRED_ATTRIBUTES.reject { |attr| data.key?(attr) } | ||
| raise ArgumentError, "Missing required attributes: #{missing_attrs.join(', ')}" unless missing_attrs.empty? | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
This validation is unnecessary, and you might break the response stream, and it's just a response. I don't think it makes sense to have a validation here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on fixes
ChatKitcodebase. The most significant updates include enforcing required attributes for thread items, fixing a typo in themime_typeparameter.Changes: