Conversation
|
Hi, we have to review some parts...however tests are missing. |
| { | ||
| public static VersionInfoBuilder With<T>(this VersionInfoBuilder builder) where T : class, IInfoProvider | ||
| private static List<String> keyValues = new List<String>(); | ||
| public static VersionInfoBuilder With<T>(this VersionInfoBuilder builder, Action<ExclusionSettings> configureOptions = null) where T : class, IInfoProvider |
There was a problem hiding this comment.
In this way configureOptions is specific for the provider configuration, but all (excluded) keys of each provider are merged in a single array (static).
There was a problem hiding this comment.
I think a better approach is using AspNet Options framework... as example you could inspect AspnetCore.Healthchecks code for it
https://github.com/dotnet/aspnetcore/tree/main/src/HealthChecks/HealthChecks/src/DependencyInjection
|
Hi, Thanks for review I will try to find a better approach , your comment is useful for the next PR. |
If you prefer, I create a new branch and support you in the first part (creating options, extension methods, ...) and then you integrate filter logic |
In the Startup.cs file we can use the below configuration to exclude some of sensitive contents
Example.
Result of the above configuration:
We can add all as well.
The final example is.