fix(install): add os.path.samefile() guard to prevent copytree same-file crash#4297
Merged
fix(install): add os.path.samefile() guard to prevent copytree same-file crash#4297
Conversation
…ile crash When AMPLIHACK_HOME points at the source tree itself, copytree_manifest would call shutil.copytree with source_dir == target_dir, causing a SameFileError crash. Add a guard using os.path.samefile() that detects this condition and skips the copy with a warning message. Fixes #4296 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Repo Guardian - PassedAll changed files in this PR are durable, production-quality additions:
No ephemeral content, temporary scripts, or point-in-time documents detected.
|
Documents the os.path.samefile() guard, symptoms, root cause, and verification steps. Links to both Python and Rust PRs. Refs: #4296 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Repo Guardian - PassedAll changed files in this PR are durable, production-quality additions:
No ephemeral content, temporary scripts, or point-in-time documents detected.
|
This was referenced Apr 10, 2026
Owner
Author
|
✅ Review complete — fix is correct and merge-ready.
|
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
AMPLIHACK_HOMEpoints at the source tree itself,copytree_manifest()callsshutil.copytree()withsource_dir == target_dir, causing aSameFileErrorcrash.Changes
src/amplihack/install.py: Addedos.path.samefile()guard inside thecopytree_manifest()for-loop, before theshutil.copytree()call. When source and target resolve to the same directory, the copy is skipped with a warning message.tests/unit/test_copytree_samefile.py: 3 regression tests covering same-dir, symlink-same-dir, and normal-copy scenarios.Testing
Fixes #4296