docs: remove misleading link from "Don't over-optimize" section#720
Open
eduardbar wants to merge 1 commit intoryanmcdermott:masterfrom
Open
docs: remove misleading link from "Don't over-optimize" section#720eduardbar wants to merge 1 commit intoryanmcdermott:masterfrom
eduardbar wants to merge 1 commit intoryanmcdermott:masterfrom
Conversation
The link to github.com/petkaantonov/bluebird/wiki/Optimization-killers was misleading — it pointed to an outdated Bluebird Promise library wiki page about V8 optimization killers that is no longer maintained or accurate for modern JavaScript engines. Replace with a general recommendation to use browser developer tools and performance profiling to identify real bottlenecks, which is more actionable and up-to-date advice. Closes ryanmcdermott#719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a misleading external link from the "Don't over-optimize" section and replaces it with more actionable, timeless advice.
Problem
The section linked to
github.com/petkaantonov/bluebird/wiki/Optimization-killers— a Bluebird Promise library wiki page about V8 optimization killers. This link is problematic because:Change
Replace the broken external link with a recommendation to use browser developer tools and performance profiling — the standard, modern approach to identifying real performance bottlenecks.
Before:
After:
Closes #719