Fix inconsistent serialization of GlobalTargetInfo#840
Merged
Conversation
mibac138
commented
Mar 19, 2026
|
Thanks! Will check in game when have time and it's merged and released |
notfood
added
fix
mibac138
force-pushed
the
sync-global-target-info
branch
from
8aa96b9 to
64b567d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in rwmt/Multiplayer-Compatibility#553
I believe this is just a simple omission that caused this issue. The cause of it is an asymmetry in reading vs writing. For reading, the code just did
ReadInt, while for writing it calledWriteSync<PlanetTile>, which consists of 2 ints.cc @sviyh as you discovered the bug. With this patch merged, the work around you did should no longer be necessary. I'd appreciate it if you could verify it, as I'm not familiar with that mod