Allow setting OpenMP flags using env var#263
Draft
thilinarmtb wants to merge 1 commit intorusty1s:masterfrom
Draft
Allow setting OpenMP flags using env var#263thilinarmtb wants to merge 1 commit intorusty1s:masterfrom
thilinarmtb wants to merge 1 commit intorusty1s:masterfrom
Conversation
6251913 to
5131f28
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 97.32% 97.28% -0.04%
==========================================
Files 11 11
Lines 224 221 -3
==========================================
- Hits 218 215 -3
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5131f28 to
f2c320a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flags to enable OpenMP depends on the compiler and it is not always
-fopenmp. This PR add the env. varOPENMP_FLAGand checks if it is setbefore applying the default flag.