Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4430b6cad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[cfg(test)] | ||
| #[must_use] | ||
| pub fn create_canonical_request( |
There was a problem hiding this comment.
Keep public canonical-request helpers in non-test builds
Adding #[cfg(test)] to this pub helper removes it from normal library builds, which is a breaking API change for any downstream code importing s3s::sig_v4::create_canonical_request (and similarly create_presigned_canonical_request). Because sig_v4 re-exports methods::*, callers that compiled before this commit will now fail with unresolved symbols outside tests.
Useful? React with 👍 / 👎.
|
Superseded by upstream PR s3s-project#570. |
Summary
Related Issue
Verification
cargo test -p s3s v4_header_auth_uses_raw_uri_path_for_canonical_request -- --nocapturecargo test -p s3s sig_v4::methods --libcargo test -p s3s ops::signature --libcargo fmt --all --check