fix(s3): preserve equals in signed object paths#2499
Closed
jlon wants to merge 1 commit intorustfs:mainfrom
Closed
fix(s3): preserve equals in signed object paths#2499jlon wants to merge 1 commit intorustfs:mainfrom
jlon wants to merge 1 commit intorustfs:mainfrom
Conversation
Signed-off-by: 80347547 <jianglong@oppo.com>
Contributor
|
CLA requirements are satisfied for this pull request. |
Contributor
Author
|
Superseded by rustfs/s3s#10. The final RustFS-side PR will only bump the s3s revision and keep the regression test after the upstream fix is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
s3sdependency used by RustFS=in SigV4 canonical object paths so signed GET requests do not fail signature verification for valid S3 object keys=Checklist
make pre-commitImpact
Additional Notes
Verification commands:
cargo fmt --all --checkcargo test -p e2e_test test_signed_get_nonexistent_object_with_trailing_equals_returns_nosuchkey -- --nocaptureThank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.