Skip to content

Wayland: Implement pointer gesture hold#4549

Draft
Murmele wants to merge 6 commits intorust-windowing:masterfrom
Murmele:pointer_gesture_hold
Draft

Wayland: Implement pointer gesture hold#4549
Murmele wants to merge 6 commits intorust-windowing:masterfrom
Murmele:pointer_gesture_hold

Conversation

@Murmele
Copy link
Copy Markdown

@Murmele Murmele commented Mar 27, 2026

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Murmele added 3 commits March 27, 2026 09:17
…pad touches

Description: Required to stop kinetic scrolling animations
Description: previously we got wl_display#1: error 1: invalid method 3 (since 1 < 3), object zwp_pointer_gestures_v1#21
Reason: This is usefull when using kinetic animations after the TouchPhase ended and the touchpad was touched again but no movement was executed. In this case the animation shall be stopped
@Murmele Murmele requested a review from kchibisov as a code owner March 27, 2026 08:22
@Murmele Murmele force-pushed the pointer_gesture_hold branch from 089600a to 78f1e72 Compare March 27, 2026 08:42
- Add more `ImePurpose` values.
- Add `ImeHints` to request particular IME behaviour.
- Add Pen input support on Wayland, Windows, and Web via new Pointer event.
- On wayland touchpad hold events are implemented to get the possibility to stop kinetic animations during scrolling
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it goes to unreleased, not here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will fix

#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub enum TouchPhase {
/// The fingers touching the touchpad, but no move happend yet
Hold,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the manual page, the use for Hold seems to stop kinetic scrolling? Maybe routing some other event from the Hold handler (Cancelled/Ended) can achieve that as well?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intended to be that this is the usecase but actually it will only signal the event

@Murmele Murmele force-pushed the pointer_gesture_hold branch from 54831f7 to 83821c4 Compare March 27, 2026 14:24
@Murmele Murmele marked this pull request as draft March 27, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants