Wayland: Implement pointer gesture hold#4549
Draft
Murmele wants to merge 6 commits intorust-windowing:masterfrom
Draft
Wayland: Implement pointer gesture hold#4549Murmele wants to merge 6 commits intorust-windowing:masterfrom
Murmele wants to merge 6 commits intorust-windowing:masterfrom
Conversation
…pad touches Description: Required to stop kinetic scrolling animations
Description: previously we got wl_display#1: error 1: invalid method 3 (since 1 < 3), object zwp_pointer_gestures_v1#21
Reason: This is usefull when using kinetic animations after the TouchPhase ended and the touchpad was touched again but no movement was executed. In this case the animation shall be stopped
089600a to
78f1e72
Compare
kchibisov
requested changes
Mar 27, 2026
winit/src/changelog/v0.31.md
Outdated
| - Add more `ImePurpose` values. | ||
| - Add `ImeHints` to request particular IME behaviour. | ||
| - Add Pen input support on Wayland, Windows, and Web via new Pointer event. | ||
| - On wayland touchpad hold events are implemented to get the possibility to stop kinetic animations during scrolling |
Member
There was a problem hiding this comment.
it goes to unreleased, not here.
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| pub enum TouchPhase { | ||
| /// The fingers touching the touchpad, but no move happend yet | ||
| Hold, |
Member
There was a problem hiding this comment.
From the manual page, the use for Hold seems to stop kinetic scrolling? Maybe routing some other event from the Hold handler (Cancelled/Ended) can achieve that as well?
Author
There was a problem hiding this comment.
It was intended to be that this is the usecase but actually it will only signal the event
54831f7 to
83821c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to users