Wayland: Popup Implementation#4543
Draft
Murmele wants to merge 17 commits intorust-windowing:masterfrom
Draft
Conversation
Description: The PopupHandler trait must not be implemented for a new type but for the WinitState. In this case the events get forwarded to this implementation
Description: wl_surface commit must be called
… because the windowid is not in the windows list.
madsmtm
added
DS - wayland
Reason: Because a normal window can have a parent window as well, like a Dialog
Reason: otherwise the child surface is anchored to the center
Reason: Because we are using the window state
Reason: it is not required after configuration anymore
Reason: otherwise the height of the client side decoration is not considered and therefore the location is shifted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an initial work and is far away from finished. It is just to state that I am working on it.
The idea is to keep using the WindowState also for the popup, just extending it for the popup. So I don't have to change anything in the winit code
Related issues: #403 and #4256
changelogmodule if knowledge of this change could be valuable to usersTODO: