Make PlatformLogWriter public and flush on Drop#96
Open
middagj wants to merge 2 commits intorust-mobile:masterfrom
Open
Make PlatformLogWriter public and flush on Drop#96middagj wants to merge 2 commits intorust-mobile:masterfrom
middagj wants to merge 2 commits intorust-mobile:masterfrom
Conversation
nl-wallet-bot
pushed a commit
to MinBZK/nl-wallet
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if it was intentional, but since #85 the PlatformLogWriter is no longer
pub. We use it to write via the tracing crate instead of log. This PR makes it public again.Next to this I added a Drop for PlatformLogWriter. Since it is a buffered writer it is natural to flush on drop.
If you are interested I could also upstream a
io::Writeimplementation that writes bytes and replaces invalid UTF-8 chars with the replacement chars (viautf8_chunks), but that might be counter-intuitive to what people expect from aio::Writeimplementation.