Avoid rewriting the preconfigured tag#87
Merged
Nercury merged 3 commits intorust-mobile:masterfrom Mar 5, 2025
Merged
Conversation
added 2 commits
March 5, 2025 10:54
In case we already have a CString tag in Config, do not attempt to rewrite it to a temporary buffer, but use it directly.
MarijnS95
reviewed
Mar 5, 2025
MarijnS95
reviewed
Mar 5, 2025
MarijnS95
approved these changes
Mar 5, 2025
Member
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Yep, that's so much nicer and clearer.
- Remove unnecessary type annotation - Replace c"" with CStr::from_bytes_with_nul for compatibility with older Rust versions
Author
|
cc @Nercury |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #83 that I uploaded after the PR was already merged :)
In case we already have a CString tag in Config, do not attempt to rewrite it to a temporary buffer, but use it directly.
@MarijnS95