Merged
Conversation
843fdc3 to
bf055c3
Compare
Dry-run check results |
bf055c3 to
acc2944
Compare
ubiratansoares
approved these changes
Mar 13, 2026
Kobzol
approved these changes
Mar 13, 2026
Member
There was a problem hiding this comment.
I was thinking about this when examining the implementation; I hoped that GitHub keeps the order. Seems not, so keeping it sorted it is.
Even better would be to actually represent the rules as fields, rather than in a container, because we use at most one rule per type anyway. But that's a more complex change.
Member
Author
|
It failed with the following error: |
Member
Author
|
I'll try again to merge this. Maybe some flakiness from github.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the empty sync-team diff we see in PRs