Improve diagnostic for when field is never read#83004
Closed
sunjay wants to merge 7 commits intorust-lang:masterfrom
Closed
Improve diagnostic for when field is never read#83004sunjay wants to merge 7 commits intorust-lang:masterfrom
sunjay wants to merge 7 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to (but does not close) #81658
This completes the first step of @pnkfelix's mentoring instructions but does not actually improve the diagnostics (yet!). The two tests are heavily reduced versions of code from the original bug report.
I've confirmed that the reduced
field-used-in-ffitest fails on nightly but passes on stable. This confirms that the regression is reproduced correctly. Thedrop-only-fieldtest is a case that @pnkfelix mentioned in his mentoring instructions. It is not a regression, but will come in handy when we make the diagnostic smarter by looking at whether the field type implementsDrop.Per the rustc-dev-guide, each test includes a comment summarizing what it is about.