Skip to content

Make unary float intrinsics generic#153934

Draft
N1ark wants to merge 7 commits intorust-lang:mainfrom
N1ark:generic-float-unops2
Draft

Make unary float intrinsics generic#153934
N1ark wants to merge 7 commits intorust-lang:mainfrom
N1ark:generic-float-unops2

Conversation

@N1ark
Copy link
Contributor

@N1ark N1ark commented Mar 16, 2026

Follow up PR to #153834 (see diff), commits split for readability

Apply the same merging to the rest of the unary float intrinsics, namely floor, ceil, trunc, round_ties_even, round, sqrt, sin, cos, exp, exp2, log, log2, log10

r? tgross35

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2026

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@N1ark N1ark changed the title Make float unary intrinsics generic Make unary float intrinsics generic Mar 16, 2026
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Linting stage2 bootstrap (stage1 -> stage2, x86_64-unknown-linux-gnu)
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/clippy-driver /checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names --sysroot /checkout/obj/build/x86_64-unknown-linux-gnu/stage1 --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zannotate-moves -Zunstable-options -Zforce-unstable-if-unmarked -Zmacro-backtrace -Csplit-debuginfo=off -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Zunstable-options --target x86_64-unknown-linux-gnu --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg -Wwarnings` (exit status: 101)
  --- stderr

  thread 'rustc' (32610) panicked at compiler/rustc_span/src/symbol.rs:2652:13:
  duplicate symbols in the rustc symbol list and the extra symbols added by the driver: ["exp", "sqrt", "log10", "round", "ceil", "log2", "floor", "log"]
  stack backtrace:
     0: __rustc::rust_begin_unwind
     1: core::panicking::panic_fmt
     2: <rustc_span::symbol::Interner>::with_extra_symbols
     3: <rustc_span::SessionGlobals>::new
---
  warning: the ICE couldn't be written to `/checkout/rustc-ice-2026-03-16T01_13_50-32609.txt`: Read-only file system (os error 30)

  note: rustc 1.96.0-nightly (f4ed0ee3f 2026-03-16) running on x86_64-unknown-linux-gnu

  note: compiler flags: -C symbol-mangling-version=v0 -Z annotate-moves -Z unstable-options -Z force-unstable-if-unmarked -Z macro-backtrace -C split-debuginfo=off -C link-args=-Wl,-z,origin -C link-args=-Wl,-rpath,$ORIGIN/../lib -Z unstable-options --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro -Z on-broken-pipe=kill -Z tls-model=initial-exec -Z allow-features=binary-dep-depinfo,proc_macro_span,proc_macro_span_shrink,proc_macro_diagnostic

  query stack during panic:
  end of query stack
  note: Clippy version: clippy 0.1.96 (f4ed0ee3f9 2026-03-16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants