Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
1d08de5 to
92b334a
Compare
oli-obk
reviewed
Mar 14, 2026
library/coretests/tests/array.rs
Outdated
| #[test] | ||
| fn extra_const_array_ops() { | ||
| let x: [u8; 4] = | ||
| const { std::array::from_fn(const |i| i + 4).map(const |x| x * 2).map(const |x| x as _) }; |
Contributor
There was a problem hiding this comment.
Also add a test with upvars (both trivial ones and ones with const Drop impls
Contributor
There was a problem hiding this comment.
And a UI test that fails if an upvar is not const Destruct
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
92b334a to
9a21f8d
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Mar 14, 2026
tests/ui/traits/const-traits/const-closure-with-indestructible-indestructible.rs
Show resolved
Hide resolved
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
9a21f8d to
cf2876e
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
2 times, most recently
from
d2537d2 to
20dfeff
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
20dfeff to
29a13cc
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
29a13cc to
bc613f8
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
bc613f8 to
5c1e5d5
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
5c1e5d5 to
02e4873
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
02e4873 to
50d7a00
Compare
Contributor
|
lgtm. Pls squash the commits as the test commit doesn't test "before this PR" behaviour but is just tied to the second commit r=me @bors delegate+ |
Contributor
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
50d7a00 to
04b3bca
Compare
Contributor
Author
|
@bors r=oli-obk |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 04b3bca with merge 629890a... Workflow: https://github.com/rust-lang/rust/actions/runs/23156680213 |
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
constify const Fn*: Destruct makes closures const destruct where their upvars are. i think this makes sense and is how this should be implemented. r? @oli-obk
rust-bors
bot
added
the
S-waiting-on-review
Contributor
|
💥 Test timed out after |
rust-bors
bot
removed
the
S-waiting-on-bors
theemathas
reviewed
Mar 17, 2026
|
|
||
| // Coroutines and closures could implement `[const] Drop`, | ||
| // Closures are [const] Destruct when all of their upvars (captures) are [const] Destruct. | ||
| ty::Closure(def, args) if cx.closure_is_const(def) => { |
Contributor
There was a problem hiding this comment.
The old and next solvers in this PR seem to treat non-const closures differently. Please test if this code has the same behavior on the old solver and the next solver:
#![feature(const_trait_impl, const_destruct)]
use std::marker::Destruct;
const fn foo(x: i32) -> impl const Destruct {
move || { std::hint::black_box(x); }
}
Contributor
Author
|
@bors retry |
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 17, 2026
… r=oli-obk constify const Fn*: Destruct makes closures const destruct where their upvars are. i think this makes sense and is how this should be implemented. r? @oli-obk
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
04b3bca to
5ff4862
Compare
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154007), which was closed. |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
bend-n
force-pushed
the
constify-const-fn-destruct
branch
from
5ff4862 to
b90abe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes closures const destruct where their upvars are. i think this makes sense
and is how this should be implemented.
r? @oli-obk